Feedback - Bug Reports

I am taking a look. I sent you a DM.

2 Likes

Iā€™m experiencing a bug in the iOS app where I canā€™t remove words from my review. The pop up window comes up but both selecting cancel and remove donā€™t do anything. I have to kill the app to get the window to go away and the word doesnā€™t get removed.

2 Likes

Hey!
This bug has been fixed and will be released with next update!

Cheers!

3 Likes

Ok thanks for the fast response!

1 Like

Thereā€™s a bit of a bug / unexpected user flow with the Decks search.

If you are not logged in on bunpro.jp (main site), you can still access deck pages, for example bunpro.jp/decks/super/supercub
You can land there e.g. if you are logged in on community.bunpro.jp, or because the site logged you out automatically with a browser tab still open.

BUT, if you try to use the search box, nothing happens, and thereā€™s no user-visible error message.
In the browser console you can see that GET https://bunpro.jp/decks/search?... returns a 500.

Perhaps some sort of user message that ā€œsearch doesnā€™t work because you are not logged inā€ would be helpful.
Or otherwise, redirecting to the login page from the deck page when not logged in.

1 Like

This is more of a systemic thing than just a single bug.

I just noticed that some Vocab items are accessible from more than one ā€˜officialā€™ URL. For example, the Vocab for Hokkaido is accessible from these 2 different URLS:

  1. https://bunpro.jp/vocabs/hokkaido-island
  2. https://bunpro.jp/vocabs/åŒ—ęµ·é“-Hokkaido-%28island

Well, okay, for some reason, the first link stopped working, but I swear it was working a few minutes ago. :thinking: Maybe by the time you read this itā€™ll start working again?

There are a couple issues with this situation.

Issue #1

First off, I need to mention that when I was accessing it via the first link, the ā€œCopy a link to this page to the clipboardā€ button would always copy the first link. But when I was accessing it via the second link, the Copy Link button would copy the second link!

Thus, according to the Copy Link button, there are two ā€˜canonicalā€™ links to the same Vocab page.

So, first issue is that the Copy Link button (ā€œCopy a link to this page to the clipboardā€) should always have the same, single, canonical URL in it. Probably this should come directly from the DB, perhaps with a dedicated ā€˜canonical URLā€™ field for each vocab ā€“ not copy it from the browser (which is how Iā€™m presuming itā€™s currently being done).

Note that this issue (#1) is about the Copy Link button. The bigger issue (#3) will be about the underlying page/data structure, although the two issues are fairly linked.

Issue #2

Second, and this is a relatively minor one, but I just want to get it out of the way: The second link contains an open-parenthesis ā€˜(ā€™, but this messes up the Hyperlink feature of these here forums, so that you canā€™t easily copy/paste the URL into a forum post. I had to manually insert a URL-encoded %28 in order to get the second link to show up without issue. Otherwise, it ends up like this:

Which leads to a 404.

So, second issue is that canonical URLs should (ideally) not contain characters that mess up the BP forumā€™s Hyperlinking feature(s). (Or maybe somehow fix the forums so that they can handle the pasting of URLs with such characters.)

Issue #3

Fundamentally, though, the main issue is that item pages (Vocab or Grammar) should have a single, unique, canonical URL associated with them (again, related to issue #1, but this time about the data rather than the UI).

It should be the same canonical URL regardless of the URL used by the browser (or whatever other inclusion mechanism) to access it. Think of it like a ā€˜permalinkā€™, although perhaps in the back-ground it might be modifiable, unlike a true permalink ā€“ but modifying it should be rare and done carefully.

There are numerous possible issues that could come up as a result of allowing different canonical-seeming URLs to bring up the same canonical page. In fact, Iā€™m having a brain fart right now and having a hard time coming up with some of them, although I had a few in mind when I first started writing this out. :sweat_smile:

A basic example, though:

User editing the same page via different URLs, but not realizing they represent the same page, may be making edits on each copy, in different browser tabs. May save edits on one tab, then switch to second tab, save those edits, effectively over-writing the edits made in the first tab.

I use a Duplicate Tabs plugin to prevent myself from doing this kind of thing, but it is defeated if the same page can be opened using two different URLs.


In general, while itā€™s generally okay for different URLs to lead to a single canonical page, the page itself should have a unique ā€˜identityā€™, accessible in the form of a single canonical URL. For much the same reasons itā€™s best to have a single canonical ID for database records. Especially when linking things. Youā€™re basically ā€˜asking for troubleā€™ by not having them.

Anyway, kinda fizzled out there due to brain fart. But I think the fact that the Copy Link button produces different URLs depending on how the page is accessed is alarming enough, IMHO. Anywhoā€¦ yeah.
:sweat_smile:

1 Like

Text in graded readers shifts around on hover making it hard to read since the hovered text overlaps with the line above.

Two notable things:

  1. Only ruby elements appear to cause the text to shift. Normal text and other clickable elements like grammar items (e.g. 恮恧) donā€™t cause the shift.
  2. Hovering over a ruby element in one line causes all of the following lines to correct themselves.

Both standard view and vertical view affected.

The image below is a particularly bad example where one line fully overlaps the previous line. Most cases arenā€™t this bad and only partially overlap.

image

Tested in Edge on Windows. Couldnā€™t replicate the issue in Safari on iOS.

1 Like

Addendum to my previous report:
I found another pair of links. They were reproducible just now; hopefully they continue to do so, so you guys can reproduce it yourselves:

Hmmm!! Bizarre! Again, the first link stopped working and now goes to 404. Maybe this is some self-correcting thing somehow?

1 Like

Hey there! Iā€™ve noticed something Iā€™d like to discuss. Itā€™s not exactly a bug, but more of an impracticality. When Iā€™m studying a vocabulary list, I often already know some of the words. However, when I mark these words as ā€œmasteredā€ while still in the ā€œlearningā€ phase, the system still counts them as ā€œviewedā€ or ā€œseen.ā€

This means that at the end of my session, instead of reviewing all 20 words, I might only end up reviewing 17 because Iā€™ve marked 3 as ā€œmastered.ā€ Consequently, the system then prompts me to learn 3 ā€œnewā€ words. But if I already know 2 of the suggested remaining three, Iā€™ll mark them as ā€œmasteredā€ too, leaving me with just one word for review. Itā€™s a bit of a loop.

I start with a big pile, then get smaller and smaller piles. Instead i would like to start with the big pile, remove ā€œmasteredā€ words along the way, and review only when 20 words have been ā€œselectedā€ (not marked as ā€œmasteredā€).

In short, Iā€™d prefer if the system didnā€™t count mastered words in the total review count before launching the review.

PS : Also, it would be great if when I mark a word as ā€œmastered,ā€ the system would move on to the next word instead of showing me the previous one.

3 Likes

This seems to be due to an issue on our end. We have been adding thousands of vocab words to our database and for a small amount the autogenerated url defaulted to the all English one. We have since updated them to default to Japanese or Japanese+English in the case that the kanji is the same.

In the two examples you included, it seems we actually have duplicate entries for them which is why there are two links. We will be going through and making sure that the duplicate ones that were generated during this spurt of new vocab are removed.

Thank you as always for the detailed bug reports! They really help in pinpoint the issue :bowing_man:

3 Likes

After completing a deck on mobile, and then switching to an existing instance of the web browser it is possible to still click on learn - this results in an error being shown instead of it being handled gracefully.

Replication:

  • Open an instance of BunPro on a web browser.
  • Open another instance in a private window or the mobile app.
  • With this second instance complete the remaining items in a deck so the deck is completed.
  • Switch back to the first instance - important that the page isnā€™t refreshed. The Learn button should still be available.
  • Click learn - this results in an error page being shown. See below.

1 Like

Hi there! This is not currently possible.
But we have got suggestions for this in the past so it might be something we look into in the future.

1 Like

Hi there!
What Vocab was this for?
Is it still showing up?

1 Like

Hi there! Thanks for the report šŸ™‡ā€ā™‚ļø

Please let us know if this issue shows up again and weā€™ll take a deeper look!

2 Likes

Very good catch!
I think I know what is causing this and have added it to my to-do list šŸ™‡ā€ā™‚ļø

2 Likes

Hi again!
Yes seems this is a bug on the old systemā€™s pages.
Will get it fixed~

1 Like

Hi there! Thanks for the feedback.

  • Next time you see this error are you able to let us know what sentence itā€™s for?
  • Does the play button (:arrow_forward:) seem to indicate that there is audio?

Some questions just straight up donā€™t have audio yet, but other ones might just be broken.

Good catch as always!
Iā€™ve added a conditional to hide this section if the details string is empty šŸ™‡ā€ā™‚ļø

2 Likes

Hi there! Good catch and thanks for the detail.
This has been fixed, and will be published shortly.

2 Likes

Hi there! Thanks for the feedback.

We are aware of this bug.

We believe this because the content isnā€™t properly wrapped in <p> tags, and is just straight text inside of a <div> with a few <br> tags.

This is on our to-do list to fix.

2 Likes