Reviews 2.0, and a whole lot more! [Beta]

Bunpro
#108

@veritas_nz Thank you very much for this update! I tried it out and it truly does look gorgeous!

I have two pieces of feedback I would like to give to you (didn’t read through the whole thread, so maybe this was mentioned already, but here goes…):

  1. On mobile, the reviews 2.0 seems to have multiple issues. For example, I cannot make use the hints functionality - something is drawn over them and intercepts the click, from what I can tell. After entering an answer, the “hint” button disappears entirely, meaning you cannot get the translation for the sentence.

  2. I am an obsessive YomiChan user and before the update, it worked on BunPro just fine. Now, it still works, but something about the new interface messes with the mouse-over functionality. Maybe there’s almost invisible spaces in-between the characters, but certain words do not get recognized correctly anymore. For example, in the sentence “育児というのは、親の思うようにはいかないものです。” (N2 Lesson 7: 1/21), the word 思う does not get recognized - instead, only 思 gets captured.
    If possible, it would be nice if Bunpro remained “yomichan-friendly”, as it makes reading the example sentences a lot easier.

Thanks and best of luck with any future improvements!

1 Like
#109

Yeah space is pretty limited on smaller screen widths, so we made adjustments to factor this in.

The link for the Keyboard Legend on thinner screens is now in the settings menu – the cog in the top left hand side – we can always re-evaluate this if it’s a bit unintuitive.

#110

I’ve been using the new beta and it looks quite nice! I wanted to bring some attention to LastPass thinking the entry field here is a password field. It’s not an “issue” as not a lot of users are using LastPass like this, but since this wasn’t the same behavior as Reviews 1.0, I thought I should bring it to attention!

image
image1899×924 52 KB

#111

Yo! Thanks for the detailed reply and for your thoughts.

Yeah rubies are definitely what should be utilised to display furigana, so I’m hesitant to stray away from it. From what I’ve seen, relatively, we’ve got a pretty complex furigana system. And as you said, hard to find other sites where furigana is used in such a way! Even Wanikani strays away from furigana entirely.

The current iteration we have for Reviews 2.0 is fine at the moment, but there are certain bugs that I think are just inherent with rubies (for example, if you hover over items in longer writeups, text occasionally shifts the content around).
This wouldn’t be an issue if the rubies were absolutely positioned, and/or were in super agnostic elements like spans and stuff. The default ruby is just the wild west in terms of browser implementation.

Transform scaling is an option! We’re about to push a fix that uses negative letter spacing, so if that doesn’t fix our issues, I’ll have a play around with your suggestion :v:

But yeah, if you see anything else that might be a good reference, flick me a DM! Cheers :sunglasses:

2 Likes
#112

Thanks for the feedback! We’re currently brainstorming some ideas for extra user feedback such as this :sunglasses:

1 Like
#113

I have a major issue that is new as of today. Is it preferred to have Reviews 2.0 bug reports in the Reviews 2.0 thread or the bugs thread?
Details: Feedback - Bug Reports - #2892 by Eradin

2 Likes
#114

I’m still not sure what the benefit of the new system is. Is it just the design? Because I prefer the old one. Will we all eventually have to change over, or can we stick with the old one?

…

Sorry to be a pain, because I know you guys work so hard to make a great site. When you introduced the new cram, that was amazing and I could see the benefit right away. This time I’m struggling.

You’re not being a pain at all! All your feedback is super helpful! It saves us lots time.

It’s mentioned briefly in the OP, but this update’s purpose is more internal in nature than feature based (Reviews is the only thing to really have changed), which might make it seem more or less pointless at first glance.

We were able to start fresh on the site’s internal code and design. The performance gains can’t be understated, and the more pages get replaced, the faster the site will feel. It also means in the future we’ll be able to push out updates faster and safer.

Bar the new Reviews design, we tried to change as little as possible with the new site (people hate change). But that being said, now is the perfect time to speak up with your feedback! We see every single thought, comment and idea that gets posted here and most of them get discussed internally one way or another.

Anyway, thanks for taking the time to post your feedback!

2 Likes
#115

Hi there! I’m assuming you are using mobile?
I’m going to push an update out later today that fixes this bug! Will tag you in it when it’s done.
Also yes please post any bugs you find in this thread and not the other! Cheers :bowing_man:

2 Likes
#116

Thanks all for your feedback! Some more Day 3 bug fixes are here.

The fixes:

Fixed more buggy sentences that were causing an infinite-hint loop

  • This should be all of them. If anyone notices any more just let me know

@Mannelito

Greatly decreased fade-in-out transition time between review sentences

@Mannelito

Fixed the form Japanese filter to properly accept Japanese text

  • There was another issue with validation and questions that had Furigana!
  • This is now fixed

@Marcus

Fixed issue where Hints Button wasn’t clickable on mobile

  • This bug was introduced after Reviews 2.0 Beta launch – sorry for the inconvenience :bowing_man:

@Mapletree @Eradin

Made amendments to furigana sizing to stop weird Kanji spacing issues

  • Reduced letter spacing and font-size of furigana rubies

@Sidgr

Thanks again ya’ll for all the feedback!

6 Likes
#117

Thank you! Of course, if the changes are for the good of the site, I’m all for them!

Thank you so much! It does indeed look fixed now! Just a request though, can we have this with a light background instead of a dark? Thank you!

Screenshot 2023-01-10 11.03.21 AM

3 Likes
#118

Hey, not sure if it’s been mentioned here or not yet, but with this new review update (which I’ve just tried out and love btw, fantastic job!!) will it be possible to add an option to have the male voice be the default for autoplay?
Asking here because I’m not sure if it would be easier to implement it with the new background work that’s been done

Thanks :slight_smile:

edit: don’t worry, I’m just not very observant.
Thanks for adding that as an option within the review. I’ll take my leave now :sweat:

3 Likes
#119

I have a few things, sorry if they were already mentioned, the thread is getting quite long!

#1 ~

^ I lied, it should be on the right because my mouse is already on that side when I hit next

#2 ~
Related to my mouse position… the play button for sentences when learning new grammar is reallly farrr awayyyy from other buttons on the page

image
image2744×324 25.1 KB

#3 ~
I feel the answer input box is just too close to the bottom of the window, I’m using mac and I keep hovering over my dock bar on the bottom (which blows up the icons and then covers the answer input box). I know this is super minor and I could change some Mac setting to fix this but…yea thought I’d mention it

#4~
Every single grammar point I learn I want to see all the sentences so I’m not really feelin the “See More” button :sweat_smile:

image
image2762×450 25.4 KB

tl;dr i’m lazy and don’t want to move my mouse or click much

3 Likes
#120

Oh, it works. Thanks a lot.

2 Likes
#121

Correct, I’m in Chrome on a Pixel 3a running Android 12.

Awesome, thank you for the very fast response! :grinning_face_with_smiling_eyes:

2 Likes
#122

Just wanted to check in to see if #2 was still causing you any issues? I’ve tested this on my end with a few browsers and it appears to be working as normal, but if there’s anything causing hiccups on your end we’d love to figure out the root cause!

1 Like
#123

I also had the same problem this morning using Firefox. The text appeared when I switched hints.

Bad feedback ignore

A separate issue usability wise is that when you make a mistake and there are alternative answers, the button to show grammar info disappears since all the space is taken for the alt answer widget. Unless you know it’s loaded below you don’t really have access. It doesn’t show any indication of being loaded either so I think it takes two key strokes to properly scroll down so it feels clunky.

Actually, it might be that I’m tapping the alternate answer (a) too fast before looking at the bar below. I’ve tried to carefully look at it better after a mistake and the toolbar is ok. I’ve also reread the keyboard shortcut page and could just press ESC.

1 Like
#124

Hi there! Thanks for replying. Unfortunately, yes. I just tried it out, and the words are still not being recognized properly, in spite of working well on other websites. For reference, I am using Firefox 108.0.2 64-bit and a resolution of 3440x1440, in case that has anything to do with it. Yomichan is also up to date, last updated in Nov. 2022. Other addons I use shouldn’t really have an impact imho.

1 Like
#125

Review sessions usually work fine but there are times where I can’t check the grammar point info.

1 Like
#126

BUG: If I’ve already completed my reviews and then click Review the review page has a loading graphic that will stay there forever - there is also an error in the console stating no sessionID could be found.

I would expect it to check for a session id and handle it gracefully with a message about there being no session instead.

Clicking on the In last 24hrs button still works so the rest of the page isn’t broken.

Browser: Firefox 108.0.1

image
image1847×685 93.4 KB

1 Like
#127

Not sure if I should post it here or elsewhere but thought it better to post it somewhere than nowhere; bug(?) report:

Doing reviews on my phone it seems that whenever I need to use っ what I’m writing disappears. For example, if I wanted to write もらっていました I would type もらって and then when I write いました the “もらって” disappears and I’m left with only いました.

I’ve stopped using the Reviews 2.0 now, so hopefully it will be better. Otherwise I really liked the new stuff! :blush:

1 Like